Dear all, the DRMAAv2 C binding is now in final draft state. Attached you can find the annotated and the official version of the specification, as well as the raw header file. Please provide your final comments on the mailing list until *April 22nd* (this Sunday). In case, we will set up a conf call for last discussions. Otherwise, the document will enter the OGF document process on next Monday. Thanks and best regards, Peter.
For the current public comment period I've following issues: 295: drmaa2_list_get(.., int pos) -> pos should be const, the implementation does not need to change it - 297 int pos -> same - 549 char **substate -> the user has to free it with "drmaa2_string_free()". Since it is just a string the user might "forget" this and use a "normal" free. Hence I would recommend to have a drmaa2_string type because all other data (which has to be freed) is drmaa2 typed. General question: I would like to have the free functions to NULL the freed pointers (in order to minimize the risk with dangling pointers). Hence I would change *all* free methods to accept ** arguments. Wouldn't this be reasonable? Why should the user always do the NULL'ing itself? He might forget or be just lazy and running later in problems, which we could avoid easily. Example: drmaa2_list_free(&list); /* some code later, I want to do something with list again, but not sure if it was freed already */ ... if (list == NULL) { /* oh it was freed already */ } else { /* not feed */ } Thanks, Daniel Am 17.04.2012 um 11:16 schrieb Peter Tröger:
Dear all,
the DRMAAv2 C binding is now in final draft state. Attached you can find the annotated and the official version of the specification, as well as the raw header file.
Please provide your final comments on the mailing list until *April 22nd* (this Sunday). In case, we will set up a conf call for last discussions. Otherwise, the document will enter the OGF document process on next Monday.
Thanks and best regards, Peter.
<drmaa-c-finaldraft-annotated.pdf><drmaa-c-finaldraft-official.pdf><drmaa2.h>-- drmaa-wg mailing list drmaa-wg@ogf.org https://www.ogf.org/mailman/listinfo/drmaa-wg
On Wed, May 9, 2012 at 4:47 PM, Daniel Gruber <dgruber@univa.com> wrote:
General question: I would like to have the free functions to NULL the freed pointers (in order to minimize the risk with dangling pointers). Hence I would change *all* free methods to accept ** arguments. Wouldn't this be reasonable?
+1 Cheers, Andre.
Why should the user always do the NULL'ing itself? He might forget or be just lazy and running later in problems, which we could avoid easily.
Example: drmaa2_list_free(&list); /* some code later, I want to do something with list again, but not sure if it was freed already */ ... if (list == NULL) { /* oh it was freed already */ } else { /* not feed */ }
Thanks,
Daniel
Am 17.04.2012 um 11:16 schrieb Peter Tröger:
Dear all,
the DRMAAv2 C binding is now in final draft state. Attached you can find the annotated and the official version of the specification, as well as the raw header file.
Please provide your final comments on the mailing list until *April 22nd* (this Sunday). In case, we will set up a conf call for last discussions. Otherwise, the document will enter the OGF document process on next Monday.
Thanks and best regards, Peter.
<drmaa-c-finaldraft-annotated.pdf><drmaa-c-finaldraft-official.pdf><drmaa2.h>-- drmaa-wg mailing list drmaa-wg@ogf.org https://www.ogf.org/mailman/listinfo/drmaa-wg
-- drmaa-wg mailing list drmaa-wg@ogf.org https://www.ogf.org/mailman/listinfo/drmaa-wg
-- Nothing is ever easy...
participants (3)
-
Andre Merzky -
Daniel Gruber -
Peter Tröger