Date: January 6, 2010 4:47:58 PM EST
Subject: Re: SAGA GridCPR API document review
Hi Derek,
Regarding the SAGA_CPR document:
- CPRFrequency (page 4) should probably have a default more like 1 hour
than 1 day, from previous machine experience.
- CPRTimeToLive (page 5) sounds like a bad idea. Checkpoints should be
kept until the job is complete, without regard for how long that is.
Otherwise you may have long-running jobs that will thereby have their
recoveries cut out from under them -- while the job innocently and
unknowingly gets swapped out for a higher priority job.
- class "directory" (page 9) seems to have nothing to do with CPR. I
hope that's all just a restatement for purposes of clarity...
- class "checkpoint" (page 10) seems to be the same thing as class
"directory". If they really are the same, then why define an identical
object? Why not just say that a checkpoint is a special instantiation
of a directory object? Or, if you're really gung-ho on the object
framework, derive a "checkpoint" class from the "directory" class...
and add one more special function (or a special constructor status?).
The other CPR_Architecture document appears to be the same as when we
last left it, and as such certainly seems fine to me.
Feel free to pass along my comments to the current document steward.
Thanks,
Nathan.