A few other comments and questions on the document after a first pass.
1. We'll need to think about the specifics of how to generate the segment
identifiers when there's a OSCARS/AutoBAHN bridging. When this happens, there are
2 very different identifier schemes, and it's not clear how an agent would
go about generating the circuit descriptor since they need to know how other
domains are going to generate their segment identifiers.
2. In the segment and circuit descriptors, there are two different relationship
names used: 'connects' and 'serialcompound'. In both cases, the relationship
is describing the constituent elements that make up the link (links in the
case of the circuit descriptor, and ports in the case of the segment
descriptor). Since they're describing the same conceptual relationship,
having the same name would be good.
3. It looks like the SIP agent is registering the segment ID. I'm curious why
it's being registered there.
4. All of the XQuery requests to the hLS are of the form "what services contain
eventType X?". This type of request can be handled using the summary
requests which has the side benefit of not embedding more XQuery into
protocol.
5. Relatedly, I'd like to specify that XPath queries be the only ones used the
TS. This way there's a hope of moving away from the XQuery-based protocols,
and their dependency on an XML Database. Since XPath can be converted to SQL
requests, that'd be much easier to transition to something else. It'd
probably also be good to specify exactly the subset of XPath to be supported
so that we don't hit the XQuery issue where you are required to have a
full-blown XPath implementation to implement the protocol. To keep the
XPath syntax simplified, it'd probably be good to eschew the use of
functions (at least in the beginning). e.g.: using /*:link[@id="XYZ"] or we
could strip off the new for the namespace and have /link[@id="XYZ"] .
6. In the TSQueryResponse example, it looks like far more is returned than I'd
expect given the query. Was this just a copy-and-paste instance?
7. The TSAddRequest wraps the individual network elements in an nml:topology
element. In the TSQueryResponse response, the individual elements are
wrapped in a 'datum'. It'd probably make sense to have the TSAddRequest wrap
the individual elements in a 'datum' as well.
8. What kinds of additional info are you thinking about in 9.2.1.9? Is this
stuff that is expected to be retrievable by the client, or is it stuff that
the MA is going to strip out?
9. I'm curious what kinds of subjects are envisioned for the SIP to MP
messages.
10. In 9.2.2.1, the client does a request for every service containing anything
on
pionier.net. That could easily become non-scalable. It might make sense
to qualify the request a bit (e.g. by including eventTypes of interest):
<nmwg:metadata metadataIdRef="meta1" id="metadata.8532851"><summary:subject>
<summary:subject>
<nmwg:eventType>http://ggf.org/ns/nmwg/characteristic/utilization/2.0</nmwg:eventType>
</summary:subject>
<nmwg:eventType>http://ogf.org/ns/nmwg/tools/org/perfsonar/service/lookup/discovery/summary/2.0</nmwg:eventType>
</nmwg:metadata>
11. Also, Jason noticed that the LS response has a datum element that it shouldn't:
<nmwg:message>
<nmwg:metadata metadataIdRef="meta1" id="metadata.8532851">
<summary:subject>
<nmwg:eventType>http://ggf.org/ns/nmwg/characteristic/utilization/2.0</nmwg:eventType>
</summary:subject>
<nmwg:eventType>http://ogf.org/ns/nmwg/tools/org/perfsonar/service/lookup/discovery/summary/2.0</nmwg:eventType>
</nmwg:metadata>
<nmwg:data metadataIdRef="metadata.8532851" id="data.14027668">
<psservice:serviceName>Lookup Service</psservice:serviceName>
<psservice:accessPoint>http://128.118.46.245:9995/perfSONAR_PS/services/hLS</psservice:accessPoint>
<psservice:serviceType>hLS</psservice:serviceType>
<psservice:serviceDescription>perfSONAR_PS Lookup Service at Penn State in University Park, PA USA</psservice:serviceDescription>
</psservice:service>
</perfsonar:subject>
</nmwg:metadata>
</nmwg:data>
</nmwg:message>