Donal, thanks for the list. Digging through the doc often makes one blind to spot inconsistencies... Comments mixed in below. I send the edited files to Andreas since he has the pen now. On 31 Mar 2005, at 11:52, Donal K. Fellows wrote:
Michel Drescher wrote:
[...] Looking pretty good (modulo the outcome of the UserId discussion ongoing in the other thread).
By intention I left this out - we didn't yet agree to either kick it out or leave it in.
Issues I've spotted on a quick read-through:
1: Section 6 is now inconsistent in its references to other terms (ProcessCount and TileSize are under POSIXApplication)
2: It is probably a good idea to move the section after the normative extensions section as well, in order to minimize forward references.
I'll add both issues to the phone conference list since it needs to be appointed to someone to give it a thorough review.
3: Resource/FileSystem/DiskSpace does not specify the units (only sensible values are bytes or 512-byte blocks; we probably want to specify bytes).
I inserted that the disk space is given in bytes.
4: Many examples throughout Resource/FileSystem and R/FS/DS are out of date.
Updated the examples.
5: Subsubsection titles for 5.5.14 and 5.5.15 have extra spaces.
Deleted where I found them.
6: 8.1.3.1 states that argument whitespace must be collapsed. What does this mean? I've had use-cases in the past where I've wanted to pass pure-whitespace arguments to programs...
Ok, seem to be a glitch/overlooked thing. I will remove the constraint from the spec and the schema.
7: Examples in 8.1.3.6 sometimes use (old) Arguments element.
Fixed.
8: Input, Output and Error elements should state that we're talking about filenames relative to some known location (the job's working directory?)
Also added to the issues list.
9: First sentence of 8.1.10.1 should read: "This element is a positive integer that specifies the soft limit on the duration of the application's execution, in seconds."
Changed.
10: All limit elements (8.1.10 through 8.1.22) should have a "Limit" suffix to their names for clarity.
Changed.
11: Minor typos in 4.2.2.5.2's source expression. The translation is correct.
Can't see any at the moment. Do you mean the square brackets? I put them in to express the exclusive boundary attribute. Or do you mean the whites paces? I used them for better visibility of elements in the expression.
12: Figures 1 and 2 *still* need reworking so they don't look like embedded powerpoint... :^)
Would you volunteer Donal? :^)
13: Need to state (in section 1) that JSDL is intended for use both on the Grid and elsewhere. This is important because it informs a number of our design decisions which would have been different had we been able to assume that we were encapsulated within some kind of service context.
Added to the issues list.
That's everything I can think of after a quick run-through. I might think of more later. :^)
Thanks again. Cheers, Michel