Hello, here is a list of the issues that I discovered in the final draft. Best regards, Tianchao Li 1. IMPORTANT (Agreement.wsdl) The following part should be removed from Agreement.wsdl <xs:element ref="wsag:AgreementServiceReference" minOccurs="0" maxOccurs="unbounded" /> and the following be removed from agreement_types.xsd <xs:element name="AgreementServiceReference" type="wsag:AgreementServiceReferenceType" /> <xs:complexType name="AgreementServiceReferenceType"> <xs:sequence> <xs:any namespace="##other" processContents="lax" /> </xs:sequence> <xs:attribute name="ServiceName" type="xs:NCName" /> </xs:complexType> AgreementServiceReference was already identified to be duplicate and should be removed. (Comment#14 of last year) 2. IMPORTANT The definition and usage of faults is different for AgreementFactory and PendingAgreementFactory. It seems that the PendingAgreementFactory has not been updated to catch up with the fault definition changes in AgreementFactory. 3. MINOR (Agreement.wsdl and AgreementFactory.wsdl) Unnecessary soap namespace definition for soap and wsa in WSDL xmlns:soap="http://schemas.xmlsoap.org/wsdl/soap/" (no reference to soap) xmlns:wsa="http://www.w3.org/2005/08/addressing" (all reference are in type definition, it is enough to define it in the schema element) 4. MINOR (agreement_types.xsd) Several element definition use separate closing element tag. This is inconsistent with the style of other element definitions. These include the following: -current- <xs:element name="ServiceTermReference" type="xs:string"> </xs:element> <xs:element name="KPITarget" type="wsag:KPITargetType"> </xs:element> <xs:element name="CustomServiceLevel" type="xs:anyType"> </xs:element> <xs:element name="CustomServiceLevel" type="xs:anyType"> </xs:element> -suggested- <xs:element name="ServiceTermReference" type="xs:string" /> <xs:element name="KPITarget" type="wsag:KPITargetType" /> <xs:element name="CustomServiceLevel" type="xs:anyType" /> <xs:element name="CustomServiceLevel" type="xs:anyType" />
Hi. I found another issue in the most recent document: <xs:simpleType name="ServiceRoleType"> <xs:restriction base="xs:string"> <xs:enumeration value="ServiceConsumer "/> <xs:enumeration value="ServiceProvider"/> </xs:restriction> </xs:simpleType> The white space after in "ServiceConsumer " needs to be deleted. Regards, Dominic
Dear all, I modified the version 40 of the spec according to the comments of Tianchao & Dominic. The new version 41 can be found here: https://forge.gridforum.org/sf/docman/do/downloadDocument/projects.graap-wg/... I removed all tags of the previous change tracking thus only the last changes are tracked. Tianchao & Dominic: Please verify that everything is correct. Jim & Oliver: Please verify the final code in your respective environment. After the telco tomorrow we should then inform the two area chairs and Greg Newby and upload the final version to the editor's pipeline. Best regards Wolfgang -- Wolfgang Ziegler www.scai.fraunhofer.de/ziegler.html Fraunhofer-Institute for Algorithms and Scientific Computing (SCAI) Schloss Birlinghoven, D-53754 Sankt Augustin, Germany Tel: +49 2241 14 2258; Fax: +49 2241 14 42258 CoreGRID Network of Excellence www.coregrid.net Collaboration Gateway www.coregrid.net/cg Institute on Resource Management and Scheduling www.coregrid.net/irms
Thanks for your effort. I have reviewed the changes with the following:
1. IMPORTANT (Agreement.wsdl) The following part should be removed from Agreement.wsdl ... AgreementServiceReference was already identified to be duplicate and should be removed. (Comment#14 of last year)
It is fixed.
2. IMPORTANT The definition and usage of faults is different for AgreementFactory and PendingAgreementFactory. It seems that the PendingAgreementFactory has not been updated to catch up with the fault definition changes in AgreementFactory.
It is fixed.
3. MINOR (Agreement.wsdl and AgreementFactory.wsdl) Unnecessary soap namespace definition for soap and wsa in WSDL xmlns:soap="http://schemas.xmlsoap.org/wsdl/soap/" <http://schemas.xmlsoap.org/wsdl/soap/%22> (no reference to soap) xmlns:wsa="http://www.w3.org/2005/08/addressing" <http://www.w3.org/2005/08/addressing%22> (all reference are in type definition, it is enough to define it in the schema element)
xmlns:soap and xmlns:wsa was removed from Agreement.wsdl but still remains in AgreementFactory.wsdl
4. MINOR (agreement_types.xsd) Several element definition use separate closing element tag. This is inconsistent with the style of other element definitions. These include the following: ...
It is fixed.
(Dominic) The white space after in "ServiceConsumer " needs to be deleted.
It is fixed. (new and minor) 6. Currently Agreement.wsdl, AgreementFactory.wsdl has the following comment before GetResourceProperty operations. <!-- resource property accessor definitions from WSRF-RP --> To improve consistency and clarity, this comment should be applied to AgreementState.wsdl, PendingAgreementFactory.wsdl before the following lines: <wsdl:operation name="GetResourceProperty"> Best regards, Tianchao Li Wolfgang Ziegler wrote:
Dear all,
I modified the version 40 of the spec according to the comments of Tianchao & Dominic. The new version 41 can be found here:
https://forge.gridforum.org/sf/docman/do/downloadDocument/projects.graap-wg/...
I removed all tags of the previous change tracking thus only the last changes are tracked.
Tianchao & Dominic: Please verify that everything is correct. Jim & Oliver: Please verify the final code in your respective environment.
After the telco tomorrow we should then inform the two area chairs and Greg Newby and upload the final version to the editor's pipeline.
Best regards
Wolfgang
Dear Tianchao, Tianchao Li schrieb/wrote: [...]
(new and minor) 6. Currently Agreement.wsdl, AgreementFactory.wsdl has the following comment before GetResourceProperty operations. <!-- resource property accessor definitions from WSRF-RP -->
To improve consistency and clarity, this comment should be applied to AgreementState.wsdl, PendingAgreementFactory.wsdl before the following lines: <wsdl:operation name="GetResourceProperty">
I am a bit confused: in the version I uploaded the comment <!-- resource property accessor definitions from WSRF-RP --> was already in PendingAgreementFactory.wsdl AgreementState.wsdl but not in AgreementFactory.wsdl Agreement.wsdl I have added to these two. I suppose this is what you intended. The updated version (including also the other changes you suggested) is here: https://forge.gridforum.org/sf/docman/do/downloadDocument/projects.graap-wg/... The change tracking again reduced to the last changes. Best regards Wolfgang
Best regards, Tianchao Li Wolfgang Ziegler wrote:
Dear all,
I modified the version 40 of the spec according to the comments of Tianchao & Dominic. The new version 41 can be found here:
https://forge.gridforum.org/sf/docman/do/downloadDocument/projects.graap-wg/...
I removed all tags of the previous change tracking thus only the last changes are tracked.
Tianchao & Dominic: Please verify that everything is correct. Jim & Oliver: Please verify the final code in your respective environment.
After the telco tomorrow we should then inform the two area chairs and Greg Newby and upload the final version to the editor's pipeline.
Best regards
Wolfgang
-- graap-wg mailing list graap-wg@ogf.org http://www.ogf.org/mailman/listinfo/graap-wg
-- Wolfgang Ziegler www.scai.fraunhofer.de/ziegler.html Fraunhofer-Institute for Algorithms and Scientific Computing (SCAI) Schloss Birlinghoven, D-53754 Sankt Augustin, Germany Tel: +49 2241 14 2258; Fax: +49 2241 14 42258 CoreGRID Network of Excellence www.coregrid.net Collaboration Gateway www.coregrid.net/cg Institute on Resource Management and Scheduling www.coregrid.net/irms
Unfortunatly there are still some issues on the final draft, since we need to keep the text consistent with the changes in the wsdl. I made a list of corrections for this issue. 1. the Section 9.4.6 Resource Property wsag:AgreementServiceReferenceList should be removed, since this was removed from the wsdl 2. the pseudo code in section 9.5.1 should now look like: <wsag:AgreementState> <wsag:State>wsag:AgreementStateDefinition</wsag:State> <xs:any##other/> * </wsag:AgreementState> 3. the description of the pseudo code has to be adopted /wsag:AgreementState The agreement state type has open content so that additional domain-specific state information can be expressed. /wsag:AgreementState/wsag:State The agreement state must be one of the following values: Pending, PendingAndTerminating, Observed, ObservedAndTerminating, Rejected, Complete or Terminated. The individual states are as described in Section 7.1. 4. the title of section 9.5.2 should be renamed to Resource Property wsag:ServiceTermState 5. the pseudo code in section 9.5.2 should now look like: <wsag:ServiceTermState termName="xs:string"> <wsag:State>wsag:ServiceTermStateDefinition</wsag:State> <wsag:Processing> <xs:any##other/> * </wsag:Processing> ? <wsag:Idle> <xs:any##other/> * </wsag:Idle> ? <xs:any##other/> * </wsag:ServiceTermState> * 6. the description of the pseudo code has to be adopted /wsag:ServiceTermState List of service states indexed by name. /wsag:ServiceTermState/@termName Name of the term to which it refers. /wsag:ServiceTermState/wsag:State The state of a service term. The state can be NotReady, Ready or Completed. /wsag:ServiceTermState/wsag:Processing Substate of Processing. /wsag:ServiceTermState/wsag:Idle Substate of Idle. 7. the title of section 9.5.3 should be renamed to Resource Property wsag:GuaranteeTermState 8. the pseudo code in section 9.5.3 should now look like: <wsag:GuaranteeTermState termName="xs:string"> <wsag:State>wsag:GuaranteeTermStateDefinition</wsag:State> <wsag:Processing> <xs:any##other/> * </wsag:Processing> ? <wsag:Idle> <xs:any##other/> * </wsag:Idle> ? <xs:any##other/> * </wsag:GuaranteeTermState> * 9. the description of the pseudo code has to be adopted /wsag:GuaranteeTermState List of guarantee states indexed by name. /wsag:GuaranteeTermState/@termName Name of the term to which it refers. /wsag:GuaranteeTermState/wsag:State The state of the guarantee. This can be NotDetermined, Fulfilled or Violated ----------------------------------------------------------------------- Oliver Wäldrich Fraunhofer-Institute for Algorithms and Scientific Computing (SCAI) Schloss Birlinghoven, D-53754 Sankt Augustin, Germany Tel: +49 2241 14 2830; Fax: +49 2241 14 42830 CoreGRID Network of Excellence www.coregrid.net Institute on Resource Management and Scheduling www.coregrid.net/irms
participants (4)
-
Dominic Battre -
Oliver Wäldrich -
Tianchao Li -
Wolfgang Ziegler