[GRAAP-WG] Issues in the final draft

20 Mar 2007

      Hello,

here is a list of the issues that I discovered in the final draft.

Best regards,
Tianchao Li

1. IMPORTANT (Agreement.wsdl) The following part should be removed from 
Agreement.wsdl

<xs:element ref="wsag:AgreementServiceReference"
  minOccurs="0" maxOccurs="unbounded" />

and the following be removed from agreement_types.xsd

    <xs:element name="AgreementServiceReference"
        type="wsag:AgreementServiceReferenceType" />

    <xs:complexType name="AgreementServiceReferenceType">
        <xs:sequence>
            <xs:any namespace="##other" processContents="lax" />
        </xs:sequence>
        <xs:attribute name="ServiceName" type="xs:NCName" />
    </xs:complexType>

AgreementServiceReference was already identified to be duplicate and 
should be removed. (Comment#14 of last year)

2. IMPORTANT The definition and usage of faults is different for 
AgreementFactory and PendingAgreementFactory. It seems that the 
PendingAgreementFactory has not been updated to catch up with the fault 
definition changes in AgreementFactory.

3. MINOR (Agreement.wsdl and AgreementFactory.wsdl) Unnecessary soap 
namespace definition for soap and wsa in WSDL
    xmlns:soap="http://schemas.xmlsoap.org/wsdl/soap/" (no reference to 
soap)
    xmlns:wsa="http://www.w3.org/2005/08/addressing" (all reference are 
in type definition, it is enough to define it in the schema element)

4. MINOR (agreement_types.xsd) Several element definition use separate 
closing element tag. This is inconsistent with the style of other 
element definitions. These include the following:

-current-
            <xs:element name="ServiceTermReference" type="xs:string">
            </xs:element>

            <xs:element name="KPITarget" type="wsag:KPITargetType">
            </xs:element>
            <xs:element name="CustomServiceLevel" type="xs:anyType">
            </xs:element>

            <xs:element name="CustomServiceLevel" type="xs:anyType">
            </xs:element>

-suggested-
            <xs:element name="ServiceTermReference" type="xs:string" />

            <xs:element name="KPITarget" type="wsag:KPITargetType" />
            <xs:element name="CustomServiceLevel" type="xs:anyType" />

            <xs:element name="CustomServiceLevel" type="xs:anyType" />