[DFDL]: Apply daffodil on S2G mission schemas
Dear Steve/Mike, we have run some of our DFDL schema through the daffodil parser and identified 3 issues described in the attached document. The second is expected, but could you please review/comment the first and the last (in red in the text ? ) Thanks This message and any attachments are intended for the use of the addressee or addressees only. The unauthorised disclosure, use, dissemination or copying (either in whole or in part) of its content is not permitted. If you received this message in error, please notify the sender and delete it from your system. Emails can be altered and their integrity cannot be guaranteed by the sender. Please consider the environment before printing this email. Michele
Michele Issue #1 <dfdl:simpleType dfdl:lengthKind="explicit" dfdl:lengthUnits="bytes" dfdl:length="4"/> This is not correct syntax. The "dfdl:" namespace prefix for a property is only used for "short form" attributes. Change to: <dfdl:simpleType lengthKind="explicit" lengthUnits="bytes" length="4"/> Issue #3 <dfdl:discriminator test="{true}"/> I think this should be: <dfdl:discriminator test="{fn:true()}"/> 23.5.2.1 Boolean functions The following additional constructor functions are defined on the boolean type. Function Meaning fn:true() Constructs the xs:boolean value 'true'. fn:false() Constructs the xs:boolean value 'false'. Regards Steve Hanson IBM Integration Bus, Hursley, UK Architect, IBM DFDL Co-Chair, OGF DFDL Working Group smh@uk.ibm.com tel:+44-1962-815848 mob:+44-7717-378890 From: Michele Zundo <michele.zundo@esa.int> To: DFDL-WG <dfdl-wg@ogf.org> Cc: Steve Hanson/UK/IBM@IBMGB, Rui Mestre <rui.mestre@deimos.com.pt>, Montserrat Piñol <mpinol@eopp.esa.int>, Maurizio De Bartolomei <Maurizio.De.Bartolomei@esa.int>, Mike Beckerle <mbeckerle.dfdl@gmail.com> Date: 25/04/2016 10:18 Subject: [DFDL]: Apply daffodil on S2G mission schemas Dear Steve/Mike, we have run some of our DFDL schema through the daffodil parser and identified 3 issues described in the attached document. The second is expected, but could you please review/comment the first and the last (in red in the text ? ) Thanks This message and any attachments are intended for the use of the addressee or addressees only. The unauthorised disclosure, use, dissemination or copying (either in whole or in part) of its content is not permitted. If you received this message in error, please notify the sender and delete it from your system. Emails can be altered and their integrity cannot be guaranteed by the sender. Please consider the environment before printing this email. Michele Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
I realize I never responded directly to this email. We created two improvement requests for the Daffodil issues raised here. https://opensource.ncsa.illinois.edu/jira/browse/DFDL-1513 is about the true vs. fn:true() issue, and the uninformative diagnostic message Daffodil produces when you write "true" but should have written "fn:true()" in a DFDL expression. https://opensource.ncsa.illinois.edu/jira/browse/DFDL-1512 is about the uninformative diagnostic when one puts a prefixed property like dfdl:length into a dfdl format annotation like dfdl:simpleType, rather than stripping off that dfdl: prefix from the property. This is such a common cut/paste error that the diagnostic message should be very specific at suggesting what is wrong. Mike Beckerle | OGF DFDL Workgroup Co-Chair | Tresys Technology | www.tresys.com Please note: Contributions to the DFDL Workgroup's email discussions are subject to the OGF Intellectual Property Policy <http://www.ogf.org/About/abt_policies.php> On Mon, Apr 25, 2016 at 5:18 AM, Michele Zundo <michele.zundo@esa.int> wrote:
Dear Steve/Mike,
we have run some of our DFDL schema through the daffodil parser and identified 3 issues described in the attached document. The second is expected, but could you please review/comment the first and the last (in red in the text ? )
Thanks
This message and any attachments are intended for the use of the addressee or addressees only. The unauthorised disclosure, use, dissemination or copying (either in whole or in part) of its content is not permitted. If you received this message in error, please notify the sender and delete it from your system. Emails can be altered and their integrity cannot be guaranteed by the sender.
Please consider the environment before printing this email.
Michele
Thanks Mike. Sent from my iPhone
On 07 Jun 2016, at 18:03, Mike Beckerle <mbeckerle.dfdl@gmail.com> wrote:
I realize I never responded directly to this email.
We created two improvement requests for the Daffodil issues raised here.
https://opensource.ncsa.illinois.edu/jira/browse/DFDL-1513 is about the true vs. fn:true() issue, and the uninformative diagnostic message Daffodil produces when you write "true" but should have written "fn:true()" in a DFDL expression.
https://opensource.ncsa.illinois.edu/jira/browse/DFDL-1512 is about the uninformative diagnostic when one puts a prefixed property like dfdl:length into a dfdl format annotation like dfdl:simpleType, rather than stripping off that dfdl: prefix from the property. This is such a common cut/paste error that the diagnostic message should be very specific at suggesting what is wrong.
Mike Beckerle | OGF DFDL Workgroup Co-Chair | Tresys Technology | www.tresys.com Please note: Contributions to the DFDL Workgroup's email discussions are subject to the OGF Intellectual Property Policy
On Mon, Apr 25, 2016 at 5:18 AM, Michele Zundo <michele.zundo@esa.int> wrote: Dear Steve/Mike,
we have run some of our DFDL schema through the daffodil parser and identified 3 issues described in the attached document. The second is expected, but could you please review/comment the first and the last (in red in the text ? )
Thanks
This message and any attachments are intended for the use of the addressee or addressees only. The unauthorised disclosure, use, dissemination or copying (either in whole or in part) of its content is not permitted. If you received this message in error, please notify the sender and delete it from your system. Emails can be altered and their integrity cannot be guaranteed by the sender.
Please consider the environment before printing this email.
Michele
This message and any attachments are intended for the use of the addressee or addressees only. The unauthorised disclosure, use, dissemination or copying (either in whole or in part) of its content is not permitted. If you received this message in error, please notify the sender and delete it from your system. Emails can be altered and their integrity cannot be guaranteed by the sender. Please consider the environment before printing this email.
participants (3)
-
Michele Zundo -
Mike Beckerle -
Steve Hanson