The right workflow for git is always a discussion, but particularly when dealing with binary document formats that github provides no delta support for.

The PR suggests your intention to contribute the document.  I think this is a good thing to do now. At minimum it prods us with emails that there is a thing to review and that you've requested that review.

A reviewer would pull your branch, check out, review the document, adding MS-word comments to it internally, then push the changes back to that same branch.

At some point the PR gets approved (ie, no unresolved comments, or comments are issues we agree to keep open.) and merged, and the branch deleted.

Is that an ok workflow?




Mike Beckerle | OGF DFDL Workgroup Co-Chair | Owl Cyber Defense | www.owlcyberdefense.com
Please note: Contributions to the DFDL Workgroup's email discussions are subject to the OGF Intellectual Property Policy



On Thu, Feb 18, 2021 at 2:54 PM Bradd Kadlecik <braddk@us.ibm.com> wrote:

Thanks, added gwde-dfdl-experience-8-v0.1.docx to working-drafts in indirection-draft branch. I assume I should wait for review before submitting pull request.


Regards,

Bradd Kadlecik
z/TPF Development
Phone: 1-845-433-1573
E-mail: braddk@us.ibm.com
2455 South Rd
Poughkeepsie, NY 12601-5400
United States


Inactive hide details for Mike Beckerle ---02/18/2021 02:39:28 PM---Bradd, You should get an invite to be a contributor to theMike Beckerle ---02/18/2021 02:39:28 PM---Bradd, You should get an invite to be a contributor to the repo. I've added you

From: Mike Beckerle <mbeckerle.dfdl@gmail.com>
To: Bradd Kadlecik <braddk@us.ibm.com>
Cc: Steve Hanson <smh@uk.ibm.com>, DFDL-WG <dfdl-wg@ogf.org>
Date: 02/18/2021 02:39 PM
Subject: [EXTERNAL] Re: Contributing to github




Bradd, You should get an invite to be a contributor to the repo....
This Message Is From an External Sender
This message came from outside your organization.
Bradd,

You should get an invite to be a contributor to the repo. I've added you with write access.

Mike Beckerle | OGF DFDL Workgroup Co-Chair | Owl Cyber Defense | www.owlcyberdefense.com
Please note: Contributions to the DFDL Workgroup's email discussions are subject to the OGF Intellectual Property Policy



On Thu, Feb 18, 2021 at 2:31 PM Bradd Kadlecik <braddk@us.ibm.com> wrote:
    Hi,

    I was unable to create a branch in github to upload the experience document for indirection. My userid there is tpfbraddk.

Regards,

Bradd Kadlecik
z/TPF Development
Phone: 1-845-433-1573
E-mail: braddk@us.ibm.com
2455 South Rd
Poughkeepsie, NY 12601-5400
United States