I merged your PR - squashed the 5 commits into one, so that the document appears to be just added. You can delete the branch if you want, or keep for future use. I was thinking about implementing this feature recently, and I am trying to come up with a test rig for it. I'd like to somehow adapt the TDML test language to support testing these concepts in some uniform way where we can all agree on what the results of a test should be, and exchange such tests. I think you have to be able to define multiple data "documents" in the TDML test case, and arrange for the "address" of each of them to be somehow embeddable in other ones to form a tree of pointed-to data blocks. Offsets will be easier, as you can do it all in the same single data document. I'm curious what you can share about how to test Brad. Thoughts? Mike Beckerle | OGF DFDL Workgroup Co-Chair | Owl Cyber Defense | www.owlcyberdefense.com Please note: Contributions to the DFDL Workgroup's email discussions are subject to the OGF Intellectual Property Policy <http://www.ogf.org/About/abt_policies.php> On Thu, Feb 18, 2021 at 5:45 PM Bradd Kadlecik <braddk@us.ibm.com> wrote:
Sounds good. Thanks for the explanation as this is my first time with git. I'll submit the PR.
Regards,
*Bradd Kadlecik* z/TPF Development ------------------------------ *Phone:* 1-845-433-1573 *E-mail:* *braddk@us.ibm.com* <braddk@us.ibm.com> 2455 South Rd Poughkeepsie, NY 12601-5400 United States
[image: Inactive hide details for Mike Beckerle ---02/18/2021 04:51:09 PM---The right workflow for git is always a discussion, but part]Mike Beckerle ---02/18/2021 04:51:09 PM---The right workflow for git is always a discussion, but particularly when dealing with binary documen
From: Mike Beckerle <mbeckerle.dfdl@gmail.com> To: Bradd Kadlecik <braddk@us.ibm.com> Cc: DFDL-WG <dfdl-wg@ogf.org>, Steve Hanson <smh@uk.ibm.com> Date: 02/18/2021 04:51 PM Subject: [EXTERNAL] Re: Contributing to github
------------------------------
The right workflow for git is always a discussion, but particularly...
*This Message Is From an External Sender* This message came from outside your organization. The right workflow for git is always a discussion, but particularly when dealing with binary document formats that github provides no delta support for.
The PR suggests your intention to contribute the document. I think this is a good thing to do now. At minimum it prods us with emails that there is a thing to review and that you've requested that review.
A reviewer would pull your branch, check out, review the document, adding MS-word comments to it internally, then push the changes back to that same branch.
At some point the PR gets approved (ie, no unresolved comments, or comments are issues we agree to keep open.) and merged, and the branch deleted.
Is that an ok workflow?
Mike Beckerle | OGF DFDL Workgroup Co-Chair | Owl Cyber Defense | *www.owlcyberdefense.com* <http://www.owlcyberdefense.com> Please note: Contributions to the DFDL Workgroup's email discussions are subject to the *OGF Intellectual Property Policy* <http://www.ogf.org/About/abt_policies.php>
On Thu, Feb 18, 2021 at 2:54 PM Bradd Kadlecik <*braddk@us.ibm.com* <braddk@us.ibm.com>> wrote:
Thanks, added gwde-dfdl-experience-8-v0.1.docx to working-drafts in indirection-draft branch. I assume I should wait for review before submitting pull request.
Regards,
*Bradd Kadlecik* z/TPF Development ------------------------------ *Phone:* 1-845-433-1573 *E-mail:* *braddk@us.ibm.com* <braddk@us.ibm.com> 2455 South Rd Poughkeepsie, NY 12601-5400 United States
[image: Inactive hide details for Mike Beckerle ---02/18/2021 02:39:28 PM---Bradd, You should get an invite to be a contributor to the]Mike Beckerle ---02/18/2021 02:39:28 PM---Bradd, You should get an invite to be a contributor to the repo. I've added you
From: Mike Beckerle <*mbeckerle.dfdl@gmail.com* <mbeckerle.dfdl@gmail.com>> To: Bradd Kadlecik <*braddk@us.ibm.com* <braddk@us.ibm.com>> Cc: Steve Hanson <*smh@uk.ibm.com* <smh@uk.ibm.com>>, DFDL-WG < *dfdl-wg@ogf.org* <dfdl-wg@ogf.org>> Date: 02/18/2021 02:39 PM Subject: [EXTERNAL] Re: Contributing to github
------------------------------
Bradd, You should get an invite to be a contributor to the repo....
*This Message Is From an External Sender* This message came from outside your organization. Bradd,
You should get an invite to be a contributor to the repo. I've added you with write access.
Mike Beckerle | OGF DFDL Workgroup Co-Chair | Owl Cyber Defense | *www.owlcyberdefense.com* <http://www.owlcyberdefense.com> Please note: Contributions to the DFDL Workgroup's email discussions are subject to the *OGF Intellectual Property Policy* <http://www.ogf.org/About/abt_policies.php>
On Thu, Feb 18, 2021 at 2:31 PM Bradd Kadlecik <*braddk@us.ibm.com* <braddk@us.ibm.com>> wrote: Hi,
I was unable to create a branch in github to upload the experience document for indirection. My userid there is tpfbraddk. Regards,
* Bradd Kadlecik* z/TPF Development
------------------------------ *Phone:* 1-845-433-1573 *E-mail:* *braddk@us.ibm.com* <braddk@us.ibm.com> 2455 South Rd Poughkeepsie, NY 12601-5400 United States
